-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: be explicit about running interface tests #2963
chore: be explicit about running interface tests #2963
Conversation
Instead of running unit, interface, interface over http, etc tests in each build step, split the running of interface tests out into their own commands and run them independently on travis, hopefully the build should be a bit faster.
the files should still have the .spec.js in the name or else the browser run will ignore them
|
That's kind of the point - I don't want the interface tests to run unless I specify the setup file with the |
so running |
TBH we have so many test suites and so many target environments it's not really feasible to run anything other than a subset of these on your laptop as smoke tests. The total CI time when you take running the tests on two flavours of node, chrome, firefox, their webworkers, electron main, electron renderer all on Mac OS, Linux and Windows, interop tests, interface tests to core, over http, over http to go-ipfs, over http in node, over http in firefox, chrome, etc, etc, etc is something like six hours. We've parallelised that in CI to bring it down to 45 minutes or so, this PR brings it down to about 30. If we can speed up the interop tests that'll fall further. On the Really, we want to do releases from CI at the end of the pipeline. That the tests pass on a developer's machine doesn't prove much - how many times have you said 'well it works locally'? I know I've said it a lot. |
We could make |
Instead of running unit, interface, interface over http, etc tests in each build step, split the running of interface tests out into their own commands and run them independently on travis, hopefully the build should be a bit faster.