This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: announce addresses via config #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2020
|
@achingbrain CI is failing with unrelated problems to this PR as far as I can tell |
|
#3411 will have fixed the CI issues, please merge master into this branch and it should go green. |
achingbrain
approved these changes
Nov 20, 2020
vasco-santos
force-pushed
the
feat/announce-addresses-via-config
branch
from
284427d to
57c1ad2
Compare
|
It is 🟢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add announces addresses via the config file and create options.
This is really useful for browser contexts, so that other peers can announce their public addresses, like dns addresses.
Ref: #3400