Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[help required] A lot of websocket connection errors #4141

Closed
ohager opened this issue Jun 20, 2022 · 1 comment · Fixed by #4142
Closed

[help required] A lot of websocket connection errors #4141

ohager opened this issue Jun 20, 2022 · 1 comment · Fixed by #4142
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@ohager
Copy link

ohager commented Jun 20, 2022

  • Version:
    from 0.14.3 to 0.15.2

  • Platform:
    In Browser (Chrome 102.0.5005.61, Linux Ubuntu 20.04)

  • Subsystem:

Severity:

Medium - A non-essential functionality does not work, performance issues, etc.

Description:

I use ipfs-core package via jsdelivr and since a few days I see a looooot of WS connection issues on local and production system.
I tried several versions, but still same result. It seems that ipfs is working, but slowing down performance significantly.

image

Probably, this is a configuration issue... but not sure what shall I do. This came out of a sudden...

Steps to reproduce the error:

I just load the dist package and start the node programmatically using almost the default config:

        const node = await window.IpfsCore.create({
          repo: "my-repo",
        });
@ohager ohager added the need/triage Needs initial labeling and prioritization label Jun 20, 2022
@achingbrain
Copy link
Member

This is a misconfiguration, we shouldn't be passing WebSocketsFilters.all as the filter on this line, instead passing no args which will use the default filter - e.g. only try to connect to wss: addresses in browsers.

This will get fixed in the next release.

@achingbrain achingbrain added kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels Jun 22, 2022
achingbrain added a commit that referenced this issue Jun 22, 2022
Fixes configuration regression, use the default websocket transport filters, e.g. only connect to wss and/or DNS addresses in the browser and anything goes in node.

Fixes: #4141
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants