This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: allow disabling mfs preload from config #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
suggested changes
Nov 28, 2018
test/core/mfs-preload.spec.js
Outdated
| @@ -56,4 +72,22 @@ describe('MFS preload', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| it('should disable preloading MFS', function (done) { | |||
| this.timeout(80 * 1000) | |||
There was a problem hiding this comment.
Surely this test doesn't need a timeout adjustment?
|
Would you mind rebasing for green CI please? |
achingbrain
force-pushed
the
allow-disabling-mfs-preload
branch
from
8ad4b9c
to
d542599
Compare
|
Done |
alanshaw
approved these changes
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
preload.enabledconfig key to turn on/off periodic mfs preloading.