Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feature object #63

Merged
merged 8 commits into from
Feb 3, 2016
Merged

feature object #63

merged 8 commits into from
Feb 3, 2016

Conversation

daviddias
Copy link
Member

ref: #58

@@ -24,7 +24,7 @@ module.exports = Command.extend({

run: (bool, json, key, value) => {
if (!key) {
throw new Error('argument \'key\' is required')
throw new Error("argument 'key' is required")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is standard codestyle things

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's stupid :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe lint in a separate commit?

@@ -77,7 +77,7 @@ describe('config', () => {
it('call config with no arguments', done => {
nexpect.spawn('node', [process.cwd() + '/src/cli/bin.js', 'config'])
.run((err, stdout, exitcode) => {
const expected = 'error argument \'key\' is required'
const expected = "error argument 'key' is required"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error argument is two words

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, apparently both vim and node understood that there was a tab char there, but github just ignored it, changing to \t:)

@daviddias daviddias changed the title WIP: feature object feature object Feb 3, 2016
@daviddias
Copy link
Member Author

@xicombd @dignifiedquire I'm getting the same "Buffer is not defined" error we were having in test-block.js, but this time, not using arrow functions is not solving the problem, ideas?

@@ -18,6 +20,7 @@ function IPFS (repo) {
repo = defaultRepo()
}
const bs = new BlockService(repo)
const ds = new DAGService(bs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ds and bs are really short and hard to distinguish (and understand) :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, +1 for explicitly naming them blockService and dagService respectively.

@dignifiedquire
Copy link
Member

@diasdavid some small nitpicks but other than that LGTM

@@ -2,10 +2,12 @@

const defaultRepo = require('./default-repo')
// const bl = require('bl')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to keep this around?

@daviddias
Copy link
Member Author

greeeen! :D

daviddias added a commit that referenced this pull request Feb 3, 2016
@daviddias daviddias merged commit 347b3d3 into master Feb 3, 2016
@daviddias daviddias deleted the feature/object branch February 3, 2016 18:34
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
* chore: dep updated

* feat: adds touch and chmod commands and metadata

Adds UnixFSv1.5 metadata support to mfs, including displaying it
when listing dirs and statting files.

Also adds `touch` and `chmod` commands to manipulate metadata in
a similar way to the unix shell.

* chore: update deps

* chore: update deps

* test: add cli tests

* fix: add missing dep

* fix: downgrade repo

* fix: fix tests after hashOnly turned to onlyHash

* test: add tests for http interface

* fix: use multipart pr

* chore: remove unecessary browser overrides

* chore: update ipfs-utils dep

* fix: fix up tests, add support for timespecs

* chore: use multipart pr

* fix: support optional mtimes
vasco-santos pushed a commit that referenced this pull request Sep 21, 2021
Bumps [aegir](https://github.com/ipfs/aegir) from 27.0.0 to 28.0.2.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v27.0.0...v28.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants