feature object #63
feature object #63
Conversation
| @@ -24,7 +24,7 @@ module.exports = Command.extend({ | |||
|
|
|||
| run: (bool, json, key, value) => { | |||
| if (!key) { | |||
| throw new Error('argument \'key\' is required') | |||
| throw new Error("argument 'key' is required") | |||
There was a problem hiding this comment.
this is standard codestyle things
There was a problem hiding this comment.
maybe lint in a separate commit?
daviddias
force-pushed
the
feature/object
branch
from
860cfd7
to
f90be15
Compare
| @@ -77,7 +77,7 @@ describe('config', () => { | |||
| it('call config with no arguments', done => { | |||
| nexpect.spawn('node', [process.cwd() + '/src/cli/bin.js', 'config']) | |||
| .run((err, stdout, exitcode) => { | |||
| const expected = 'error argument \'key\' is required' | |||
| const expected = "error argument 'key' is required" | |||
There was a problem hiding this comment.
error argument is two words
There was a problem hiding this comment.
interesting, apparently both vim and node understood that there was a tab char there, but github just ignored it, changing to \t:)
daviddias
force-pushed
the
feature/object
branch
from
f90be15
to
33b0f18
Compare
daviddias
force-pushed
the
feature/object
branch
from
33b0f18
to
bf15330
Compare
|
@xicombd @dignifiedquire I'm getting the same "Buffer is not defined" error we were having in test-block.js, but this time, not using arrow functions is not solving the problem, ideas? |
| @@ -18,6 +20,7 @@ function IPFS (repo) { | |||
| repo = defaultRepo() | |||
| } | |||
| const bs = new BlockService(repo) | |||
| const ds = new DAGService(bs) | |||
There was a problem hiding this comment.
ds and bs are really short and hard to distinguish (and understand) :/
There was a problem hiding this comment.
yeah, +1 for explicitly naming them blockService and dagService respectively.
|
@diasdavid some small nitpicks but other than that LGTM |
| @@ -2,10 +2,12 @@ | |||
|
|
|||
| const defaultRepo = require('./default-repo') | |||
| // const bl = require('bl') | |||
There was a problem hiding this comment.
any reason to keep this around?
|
greeeen! :D |
* chore: dep updated * feat: adds touch and chmod commands and metadata Adds UnixFSv1.5 metadata support to mfs, including displaying it when listing dirs and statting files. Also adds `touch` and `chmod` commands to manipulate metadata in a similar way to the unix shell. * chore: update deps * chore: update deps * test: add cli tests * fix: add missing dep * fix: downgrade repo * fix: fix tests after hashOnly turned to onlyHash * test: add tests for http interface * fix: use multipart pr * chore: remove unecessary browser overrides * chore: update ipfs-utils dep * fix: fix up tests, add support for timespecs * chore: use multipart pr * fix: support optional mtimes
Bumps [aegir](https://github.com/ipfs/aegir) from 27.0.0 to 28.0.2. - [Release notes](https://github.com/ipfs/aegir/releases) - [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md) - [Commits](ipfs/aegir@v27.0.0...v28.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
ref: #58