Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add /api/v0/config endpoint #72

Merged
merged 1 commit into from
Feb 26, 2016
Merged

Add /api/v0/config endpoint #72

merged 1 commit into from
Feb 26, 2016

Conversation

fbaiodias
Copy link
Member

Implements the /api/v0/config as specified at ipfs-inactive/http-api-spec#29

Related to #49

@daviddias daviddias mentioned this pull request Feb 26, 2016
14 tasks
@fbaiodias fbaiodias force-pushed the feature/http-api-config branch 2 times, most recently from 598c1fc to 3056120 Compare February 26, 2016 12:06
@fbaiodias
Copy link
Member Author

Updated route to allow any HTTP method as per discussion on ipfs-inactive/http-api-spec#29 (comment)

},

handler: (request, reply) => {
const node = new IPFS()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at https://github.com/ipfs/js-ipfs/blob/master/src/http-api/resources/id.js#L1

There is only one IPFS node instance per http-api daemon run

@daviddias
Copy link
Member

Other than #72 (comment). LGTM :)

@fbaiodias
Copy link
Member Author

@diasdavid thanks for the review. I've just updated the PR with the comments and using the ipfs daemon node instance :)

daviddias added a commit that referenced this pull request Feb 26, 2016
@daviddias daviddias merged commit 7d21f38 into master Feb 26, 2016
@daviddias daviddias deleted the feature/http-api-config branch February 26, 2016 16:57
@daviddias
Copy link
Member

rad! thank you @xicombd :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants