This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add /api/v0/config endpoint #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbaiodias
force-pushed
the
feature/http-api-config
branch
2 times, most recently
from
598c1fc
to
3056120
Compare
|
Updated route to allow any HTTP method as per discussion on ipfs-inactive/http-api-spec#29 (comment) |
fbaiodias
force-pushed
the
feature/http-api-config
branch
from
3056120
to
2ca8d97
Compare
| }, | ||
|
|
||
| handler: (request, reply) => { | ||
| const node = new IPFS() |
There was a problem hiding this comment.
look at https://github.com/ipfs/js-ipfs/blob/master/src/http-api/resources/id.js#L1
There is only one IPFS node instance per http-api daemon run
|
Other than #72 (comment). LGTM :) |
fbaiodias
force-pushed
the
feature/http-api-config
branch
from
2ca8d97
to
cf0ac05
Compare
|
@diasdavid thanks for the review. I've just updated the PR with the comments and using the ipfs daemon node instance :) |
|
rad! thank you @xicombd :D |
This was referenced Feb 27, 2016
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
/api/v0/configas specified at ipfs-inactive/http-api-spec#29Related to #49