fix: validator select should return if no callback (#15)

Author: vasco-santos

README.md

@@ -120,11 +120,11 @@ const ipns = require('ipns')
 const validator = ipns.validator
 ```
 
-Contains an object with `validate (marshalledData, key, callback)` and `select (dataA, dataB, callback)` functions.
+Contains an object with `validate (marshalledData, key, callback)` and `select (dataA, dataB, [callback])` functions.
 
 The `validate` function aims to verify if an IPNS record is valid. First the record is unmarshalled, then the public key is obtained and finally the record is validated (signature and validity are verified).
 
-The `select` function is responsible for deciding which ipns record is the best (newer) between two records. Both records are unmarshalled and their sequence numbers are compared. If the first record provided is the newer, the operation result will be `0`, otherwise the operation result will be `1`.
+The `select` function is responsible for deciding which ipns record is the best (newer) between two records. Both records are unmarshalled and their sequence numbers are compared. If the first record provided is the newer, the operation result will be `0`, otherwise the operation result will be `1`. If a callback is not provided, the response is returned.
 
 ## API
 

src/index.js

@@ -311,7 +311,13 @@ const validator = {
     const entryA = unmarshal(dataA)
     const entryB = unmarshal(dataB)
 
-    callback(null, entryA.sequence > entryB.sequence ? 0 : 1)
+    const index = entryA.sequence > entryB.sequence ? 0 : 1
+
+    if (typeof callback !== 'function') {
+      return index
+    }
+
+    callback(null, index)
   }
 }
 

test/index.spec.js

@@ -323,6 +323,27 @@ describe('ipns', function () {
     })
   })
 
+  it('should use validator.select to select the first record because it is newer without using callback', (done) => {
+    const sequence = 0
+    const validity = 1000000
+
+    ipns.create(rsa, cid, sequence, validity, (err, entry) => {
+      expect(err).to.not.exist()
+
+      ipns.create(rsa, cid, (sequence + 1), validity, (err, newEntry) => {
+        expect(err).to.not.exist()
+
+        const marshalledData = ipns.marshal(entry)
+        const marshalledNewData = ipns.marshal(newEntry)
+
+        const valid = ipns.validator.select(marshalledNewData, marshalledData)
+
+        expect(valid).to.equal(0) // new data is the selected one
+        done()
+      })
+    })
+  })
+
   it('should use validator.select to select the second record because it is newer', (done) => {
     const sequence = 0
     const validity = 1000000