coreapi/unixfs: don't create an additional IpfsNode for --only-hash #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMure
force-pushed
the
simplify-only-hash
branch
2 times, most recently
from
72d6494
to
bb4212e
Compare
|
For a bit more context, we use Fx to override some data pipeline components. As the previous code was creating another |
hacdias
force-pushed
the
simplify-only-hash
branch
from
bb4212e
to
5fc4ed3
Compare
|
@hacdias can that be merged now? |
hacdias
approved these changes
Mar 19, 2024
hacdias
force-pushed
the
simplify-only-hash
branch
from
5fc4ed3
to
bd9c6cf
Compare
|
Thank you! |
mvdan
added a commit
to mvdan/go-dvote
that referenced
this pull request
May 6, 2024
The only API change is BuildCfg.NilRepo being removed as unnecessary in ipfs/kubo#10184.
p4u
pushed a commit
to vocdoni/vocdoni-node
that referenced
this pull request
May 8, 2024
The only API change is BuildCfg.NilRepo being removed as unnecessary in ipfs/kubo#10184.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks to me that we don't need to create a full
IpfsNodefor--only-hash, we only need a null blockstore to simulate adding the data.This also remove entirely the
NilRepooption when creatingIpfsNode, as it looked like a no longer necessary workaround to me.