gateway: /version tests, add CurrentCommit

[ghost]

I'm not 100% sure this is a good idea, but I though I'd put it up for discussion. Chatted about this briefly with @harlantwood, and think it's useful.

Need to build with make build so that repo/config.CurrentCommit gets set, otherwise it'll just be an empty string.

[ghost]

Some of these CircleCI failures are horrible :/

not ok 41 - 'ipfs add -r' output looks good

None look related to this PR. Damn, we really need to sort this out.

[whyrusleeping]

yeah, the random CI failures have gotten steadily worse in the past few weeks... :/

on topic: I think adding this to the version endpoint should be fine

[ghost]

I have a better idea, let's remove :8080/version and enable :5001/api/v0/version instead.

[ghost]

Output is nice and machine readable, plus we can kill some code

{
  "Version": "0.3.10-dev",
  "Commit": "20b06a4",
  "Repo": "2"
}

[whyrusleeping]

mmm, the version endpoint on the gateway is something i wanted for ease of debugging purposes. i'd prefer to keep it there

[harlantwood]

Same, I'd like to get the version running on IPFS.io ....

[ghost]

What I mean is, the API is accessible via the Gateway anyhow, so it's :8080/version vs. :8080/api/v0/version, while the latter is even machine readable.

[ghost]

I'll just do both :8080/version and :8080/api/v0/version for now

[harlantwood]

Ah, I'm happy with either or both, as long as I can hit them on ipfs.io:80 ...

[whyrusleeping]

This LGTM

[jbenet]

yeah i want to keep both too.

[jbenet]

LGTM

[rht]

!!

@lgierth as of this commit, 9beebc9, the test file needs to be updated too.

In particular, https://github.com/ipfs/go-ipfs/blob/9beebc9779a765a567b20e5ac9915467685802e9/test/sharness/t0110-gateway.sh#L114, version needs to be removed from the sanitization list. Did this particular test pass?

[ghost]

It doesn't look like it was even run... :/

[jbenet]

hmmm is that not running then?