fuse travis-ci #2120

thelinuxkid · 2015-12-23T07:05:30Z

Tests passed https://travis-ci.org/thelinuxkid/go-ipfs/builds/98464151.

whyrusleeping · 2015-12-28T20:57:43Z

core/core.go

-	if err != nil {
-		return err
+	if n.PrivateKey == nil {
+		if err := n.LoadPrivateKey(); err != nil {


maybe instead of having this, we should probably just make LoadPrivateKey not fail if called while the key is already loaded

thelinuxkid · 2015-12-29T03:24:40Z

Yes. I was afraid to break something but that makes sense. Updated and tests are passing locally.

thelinuxkid · 2016-01-13T18:19:47Z

Working on a rebase for this

jbenet · 2016-01-14T03:36:31Z

Great thanks!
On Wed, Jan 13, 2016 at 13:19 Andres Buritica notifications@github.com
wrote:

Working on a rebase for this

—
Reply to this email directly or view it on GitHub
#2120 (comment).

thelinuxkid · 2016-01-15T06:40:20Z

Rebased. I am getting unrelated errors on TestFilePersistence (https://travis-ci.org/thelinuxkid/go-ipfs/jobs/102521435#L252) and TestMultipleDirs (https://travis-ci.org/thelinuxkid/go-ipfs/jobs/102521435#L255). I will try to take a look at them this weekend.

rht · 2016-01-23T05:44:56Z

@thelinuxkid the travis-ci err has been logged in #2002. I think this just need a rerun.

jbenet · 2016-01-24T00:55:06Z

core/core.go

-	if n.Identity == "" || n.Peerstore == nil {
-		return errors.New("loaded private key out of order.")
+	if n.PrivateKey != nil {
+		return nil


im curious why this had to be added? is there a race condition somewhere?

See @whyrusleeping's response to my first comment in this PR.

ah makes sense thanks

jbenet · 2016-01-24T01:39:20Z

I re-ran tests, the travis go one keeps failing... odd.
Ooof, the times bumped up to 14min in linux and 7min in osx. rough!
It is very useful to have fuse though.
It's silly for travis-ci to force install every time, i think we should contact them about using dockerfiles so that the FUSE image can be cached forever.

@whyrusleeping and @chriscool could you take a look at these run outputs and confirm all looks good? (i.e. testing fuse as we expect it to be tested, etc):

chriscool · 2016-01-24T10:01:42Z

My concern with this is that docker is not available so t0300 is not run:

*** t0300-docker-image.sh ***

./t0300-docker-image.sh

lib/test-lib.sh: line 45: type: docker: not found

# TEST_VERBOSE=1

# TEST_NO_FUSE=

# TEST_EXPENSIVE=1

�[36m1..0 # SKIP skipping docker tests, docker not available�(B�[m

Maybe we could have the tests run in both configurations so that both fuse tests and tests with docker can be run?

jbenet · 2016-01-24T10:27:20Z

Maybe we could have the tests run in both configurations so that both fuse tests and tests with docker can be run?

yeah that sounds good. do we know how to set this up?

i wish we could pay travis money to add to the number of workers we get. sigh. they keep not letting me pay them!!

chriscool · 2016-01-24T12:34:57Z

@jbenet I am not sure it is possible to have both kind of tests.

I am testing things on this PR to see if it's possible: #2241

jbenet · 2016-01-24T13:56:05Z

@chriscool we should be able to have two different builders with different env flags. the ipfsbot account should let you experiment with travis, it has perms there.

chriscool · 2016-01-24T14:59:51Z

@jbenet according to the result of PR #2241, it looks like when "dist: trusty" is set in the .travis.yml file, then docker is not available. So it looks like we might just want to remove "dist: trusty" from .travis.yml, and then we don't need two different builders. One sharness build will test both fuse and docker.

@thelinuxkid was there a reason you added, or uncommented, "dist: trusty" into .travis.yml?

thelinuxkid · 2016-01-24T16:37:03Z

@jbenet fuse was added on trusty build: #2023, travis-ci/travis-ci#1100 (comment)

thelinuxkid · 2016-01-24T16:39:09Z

FWIT fuse module is already installed on trusty: thelinuxkid@764e756, https://travis-ci.org/thelinuxkid/go-ipfs/builds/104456298.

chriscool · 2016-01-24T17:08:09Z

@thelinuxkid yeah but it looks like if we don't specify "dist: trusty", we can have both fuse and also docker.

thelinuxkid · 2016-01-25T03:30:56Z

I am pro containers. Specially if it eliminates the need to depend on travis' build images. But, I know nothing of its support in travis. Having said that, I removed the explicit trusty distribution (https://travis-ci.org/thelinuxkid/go-ipfs/builds/104545197) and travis still used trusty (https://travis-ci.org/thelinuxkid/go-ipfs/jobs/104545198#L14). Is that some sort of confusion...bug...is trusty now the default?

thelinuxkid · 2016-01-25T04:20:48Z

BTW except for #2214 (which is resolved but needs to be implemented) and stalls, I am not getting any more travis errors.

chriscool · 2016-01-25T07:03:23Z

@thelinuxkid yeah, it looks like Docker works now on Travis. So now this PR LGTM! Thanks!

chriscool · 2016-01-27T12:38:36Z

@whyrusleeping or @jbenet could you take a look at merging this?
The test failures are not related and have been seen elsewhere.

rht · 2016-01-27T12:40:05Z

This needs a rebase from @thelinuxkid

jbenet · 2016-01-27T21:57:03Z

Or Anyone can rebase and PR again
On Wed, Jan 27, 2016 at 04:40 rht notifications@github.com wrote:

This needs a rebase from @thelinuxkid https://github.com/thelinuxkid

—
Reply to this email directly or view it on GitHub
#2120 (comment).

thelinuxkid · 2016-01-27T22:31:43Z

Rebased. Travis tests failed in a weird way. Rerunning. Will report.

chriscool · 2016-01-27T22:39:35Z

There is this go test failure:

--- FAIL: TestFilePersistence (0.22s)
    ipns_test.go:189: Closed, opening new fs
    ipns_test.go:195: open /tmp/fusetest063103241/local/atestfile: no such file or directory
--- FAIL: TestMultipleDirs (0.24s)
    ipns_test.go:206: make a top level dir
    ipns_test.go:212: write a file in it
    ipns_test.go:217: sub directory
    ipns_test.go:222: file in that subdirectory
    ipns_test.go:228: closing mount, then restarting
    ipns_test.go:88: stat /tmp/fusetest677160995/local/test1: no such file or directory
FAIL
FAIL    github.com/ipfs/go-ipfs/fuse/ipns   7.021s

but it's known and not related.

thelinuxkid · 2016-01-27T23:03:11Z

@chriscool yep. It's addressed here: #2214. Everything else looks good.

whyrusleeping · 2016-02-03T19:37:20Z

this looks good to me, mind rebasing on latest master?

chriscool · 2016-02-03T20:44:55Z

@thelinuxkid do you want me to rebase on master?

thelinuxkid · 2016-02-04T01:57:24Z

@chriscool just rebased. Thanks.

thelinuxkid · 2016-02-04T02:19:40Z

Still getting the test failures from #2214. I will try to work on that tomorrow and/or Friday if no one else can pick it up.

rht · 2016-02-06T06:55:43Z

Why did the #2214 happen twice specifically here?

thelinuxkid · 2016-02-06T07:17:42Z

@rht Because this enables the fuse tests

thelinuxkid · 2016-02-06T07:25:25Z

I rebased and the travis tests were failing. So I reset --hard upstream/master and pushed to see if I had broken anything. That closed this PR because Github detected no new commits. I pushed again with the changes this time but it won't reopen. Sorry. I should have tested locally instead of relaying on travis.

jbenet added the backlog label Dec 23, 2015

thelinuxkid mentioned this pull request Dec 23, 2015

FUSE in CI #2023

Open

2 tasks

ghost added the kind/test Testing work label Dec 23, 2015

whyrusleeping reviewed Dec 28, 2015
View reviewed changes

thelinuxkid force-pushed the master branch from 5379c41 to 17cdfb5 Compare December 29, 2015 03:03

thelinuxkid mentioned this pull request Dec 29, 2015

Make master green again! #2002

Closed

3 tasks

daviddias removed the backlog label Jan 2, 2016

thelinuxkid force-pushed the master branch from 17cdfb5 to ce447eb Compare January 15, 2016 05:02

thelinuxkid force-pushed the master branch 2 times, most recently from fab42c9 to be219bf Compare January 17, 2016 19:56

jbenet reviewed Jan 24, 2016
View reviewed changes

thelinuxkid force-pushed the master branch from be219bf to 6ea702c Compare January 24, 2016 01:19

chriscool added the RFM label Jan 27, 2016

thelinuxkid force-pushed the master branch from ae4cce8 to 853e536 Compare January 27, 2016 22:02

chriscool mentioned this pull request Jan 29, 2016

Fuse and docker tests together #2241

Closed

rht mentioned this pull request Feb 2, 2016

Sprint: February 1 ipfs/team-mgmt#88

Closed

thelinuxkid force-pushed the master branch from 853e536 to 4331a9f Compare February 4, 2016 01:56

thelinuxkid force-pushed the master branch from 4331a9f to 9ee96b1 Compare February 6, 2016 01:50

thelinuxkid closed this Feb 6, 2016

thelinuxkid force-pushed the master branch from 9ee96b1 to 5a0b802 Compare February 6, 2016 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fuse travis-ci #2120

fuse travis-ci #2120

thelinuxkid commented Dec 23, 2015

whyrusleeping Dec 28, 2015

thelinuxkid commented Dec 29, 2015

thelinuxkid commented Jan 13, 2016

jbenet commented Jan 14, 2016

thelinuxkid commented Jan 15, 2016

rht commented Jan 23, 2016

jbenet Jan 24, 2016

thelinuxkid Jan 24, 2016

jbenet Jan 24, 2016

jbenet commented Jan 24, 2016

chriscool commented Jan 24, 2016

jbenet commented Jan 24, 2016

chriscool commented Jan 24, 2016

jbenet commented Jan 24, 2016

chriscool commented Jan 24, 2016

thelinuxkid commented Jan 24, 2016

thelinuxkid commented Jan 24, 2016

chriscool commented Jan 24, 2016

thelinuxkid commented Jan 25, 2016

thelinuxkid commented Jan 25, 2016

chriscool commented Jan 25, 2016

chriscool commented Jan 27, 2016

rht commented Jan 27, 2016

jbenet commented Jan 27, 2016

thelinuxkid commented Jan 27, 2016

chriscool commented Jan 27, 2016

thelinuxkid commented Jan 27, 2016

whyrusleeping commented Feb 3, 2016

chriscool commented Feb 3, 2016

thelinuxkid commented Feb 4, 2016

thelinuxkid commented Feb 4, 2016

rht commented Feb 6, 2016

thelinuxkid commented Feb 6, 2016

thelinuxkid commented Feb 6, 2016

fuse travis-ci #2120

fuse travis-ci #2120

Conversation

thelinuxkid commented Dec 23, 2015

whyrusleeping Dec 28, 2015

Choose a reason for hiding this comment

thelinuxkid commented Dec 29, 2015

thelinuxkid commented Jan 13, 2016

jbenet commented Jan 14, 2016

thelinuxkid commented Jan 15, 2016

rht commented Jan 23, 2016

jbenet Jan 24, 2016

Choose a reason for hiding this comment

thelinuxkid Jan 24, 2016

Choose a reason for hiding this comment

jbenet Jan 24, 2016

Choose a reason for hiding this comment

jbenet commented Jan 24, 2016

chriscool commented Jan 24, 2016

jbenet commented Jan 24, 2016

chriscool commented Jan 24, 2016

jbenet commented Jan 24, 2016

chriscool commented Jan 24, 2016

thelinuxkid commented Jan 24, 2016

thelinuxkid commented Jan 24, 2016

chriscool commented Jan 24, 2016

thelinuxkid commented Jan 25, 2016

thelinuxkid commented Jan 25, 2016

chriscool commented Jan 25, 2016

chriscool commented Jan 27, 2016

rht commented Jan 27, 2016

jbenet commented Jan 27, 2016

thelinuxkid commented Jan 27, 2016

chriscool commented Jan 27, 2016

thelinuxkid commented Jan 27, 2016

whyrusleeping commented Feb 3, 2016

chriscool commented Feb 3, 2016

thelinuxkid commented Feb 4, 2016

thelinuxkid commented Feb 4, 2016

rht commented Feb 6, 2016

thelinuxkid commented Feb 6, 2016

thelinuxkid commented Feb 6, 2016