Add Server field in HTTP API response header #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
patch-1
branch
3 times, most recently
from
a3b0c46
to
5965f66
Compare
|
Tests are passing. One of Travis builds randomly hanged. |
| @@ -24,6 +24,7 @@ test_ls_cmd() { | |||
| printf "Access-Control-Allow-Headers: X-Stream-Output, X-Chunked-Output\r\n" >>expected_output && | |||
| printf "Access-Control-Expose-Headers: X-Stream-Output, X-Chunked-Output\r\n" >>expected_output && | |||
| printf "Content-Type: text/plain\r\n" >>expected_output && | |||
| printf "Server: go-ipfs/%s\r\n" $(ipfs version | cut -d" " -f 3) >>expected_output && | |||
There was a problem hiding this comment.
Use ipfs version -n instead of cut
Just to make very sure we don't run into any superweird portability issues
Kubuxu
force-pushed
the
patch-1
branch
2 times, most recently
from
8035a3a
to
f44eaf3
Compare
|
I've addressed your comments. Tests are passing. |
|
👍 |
Kubuxu
force-pushed
the
patch-1
branch
2 times, most recently
from
9e74a0c
to
1d6e577
Compare
| @@ -24,6 +24,7 @@ test_ls_cmd() { | |||
| printf "Access-Control-Allow-Headers: X-Stream-Output, X-Chunked-Output\r\n" >>expected_output && | |||
| printf "Access-Control-Expose-Headers: X-Stream-Output, X-Chunked-Output\r\n" >>expected_output && | |||
| printf "Content-Type: text/plain\r\n" >>expected_output && | |||
| printf "Server: go-ipfs/%s\r\n" $(ipfs version -n) >>expected_output && | |||
There was a problem hiding this comment.
Sorry for the delayed feedback -- it looks like circle-ci is failing because of the ordering of the expected headers -- now that server: is being set first, it needs to be expected first
👍 ❤️ apart from that
There was a problem hiding this comment.
It is weird as Travis was successful.
Resolves ipfs#625 Included in tests. License: MIT Signed-off-by: Jakub (Kubuxu) Sztandera <kubuxu@gmail.com>
|
This time both CircleCI and Travis went through. I've changed nothing. |
|
Yep LGTM now, thanks! |
ghost
added
the
jbenet
added a commit
that referenced
this pull request
Jan 22, 2016
Add Server field in HTTP API response header
|
LGTM Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #625