use correct protocol names for ipfs services #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
feat/versioned-protos
branch
from
bbe17d1
to
0390407
Compare
whyrusleeping
added
need/review
| @@ -8,7 +8,8 @@ import ( | |||
| protocol "gx/ipfs/Qmf4ETeAWXuThBfWwonVyFqGFSgTWepUDEr1txcctvpTXS/go-libp2p/p2p/protocol" | |||
| ) | |||
|
|
|||
| var ProtocolBitswap protocol.ID = "/ipfs/bitswap" | |||
| var ProtocolBitswap protocol.ID = "/ipfs/bitswap/1.0.0" | |||
|
LGTM |
|
👌🏽 |
|
@diasdavid since my browser doesnt support emojis for some reason, i'm assuming box box means 'LGTM'
|
|
It was my new favourite emoji "IPFS core developer: builds the distributed Web.. can't get emojis to work on his browser" |
|
📦 📦 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to using the correct protocol strings for bitswap dht and diagnostics
closes #3044
cc @diasdavid
License: MIT
Signed-off-by: Jeromy why@ipfs.io