Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dht: degrade 'no addresses' from error to warning #3233

Closed
wants to merge 1 commit into from
Closed

dht: degrade 'no addresses' from error to warning #3233

wants to merge 1 commit into from

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Sep 17, 2016

Resolves #2495

@Kubuxu Kubuxu added the status/in-progress In progress label Sep 17, 2016
@whyrusleeping
Copy link
Member

@Kubuxu leave off the makefile changes. And only drop it to a warning. Until we resolve the issue i don't want to have it slip away into oblivion

@Kubuxu
Copy link
Member Author

Kubuxu commented Sep 18, 2016

Sorry about the makefile changes, based off a wrong branch.

@Kubuxu Kubuxu closed this Sep 18, 2016
@Kubuxu Kubuxu reopened this Sep 18, 2016
@Kubuxu Kubuxu added status/in-progress In progress and removed status/in-progress In progress labels Sep 18, 2016
@Kubuxu Kubuxu changed the title dht: degrade 'no addresses' from error to debug dht: degrade 'no addresses' from error to warning Sep 18, 2016
@Kubuxu
dht: degrade 'no addresses' from error to warning
63c9f88 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Copy link
Member Author

Kubuxu commented Sep 19, 2016

It might be better to lower it to Info so it doesn't how on normal user's console.

@whyrusleeping
Copy link
Member

@Kubuxu warnings dont show up by default, I think warning is fine for now

@whyrusleeping
Copy link
Member

@Kubuxu actually....... could you move this change to the https://github.com/libp2p/go-libp2p-kad-dht repo?

@Kubuxu
Copy link
Member Author

Kubuxu commented Sep 28, 2016

Moved to libp2p/go-libp2p-kad-dht#15

@Kubuxu Kubuxu closed this Sep 28, 2016
@Kubuxu Kubuxu removed the status/in-progress In progress label Sep 28, 2016
@Kubuxu Kubuxu deleted the fix/dht/handler-log-degrade branch February 27, 2017 20:39
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping