Gateway: Replace Target Node Data when Exists on POST #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #3923 |
te0d
force-pushed
the
fix/gateway/post-existing
branch
from
d6e7d9d
to
205ebd8
Compare
|
@Kubuxu @diasdavid @lgierth want to review this? I dont have much insight into the gateway code |
|
Hey @te0d, thanks for bearing with us! The proposal makes sense -- we shouldn't have allowed POST to existing nodes in the first place, but it's already there so the links-preserving mode you propose is the best thing to do. I'll set a few hours aside for reviewing the code over the weekend -- could you rebase it on master in the meantime? Thanks! |
Previously, if the specified path of a POST request existed, the newly generated DAG would have a root of the specified path instead of only modifying the data of the existing DAG at that path. These changes modify behavior so that the entire tree structure of the initially specified root CID is maintained, and the only change is the Data at the specified path. License: MIT Signed-off-by: Tom O'Donnell <todonnell@gmail.com>
The previous commit would fail when an empty directory was specified. This commit checks if the empty directory is specified, and will return an empty directory as it did previously. Also added a test case which verifies that a PUT to an existing file for a given DAG will overwrite its contents and return the correct new DAG. License: MIT Signed-off-by: Tom O'Donnell <todonnel91@gmail.com>
te0d
force-pushed
the
fix/gateway/post-existing
branch
from
205ebd8
to
c0501dd
Compare
|
@lgierth I believe I've rebased it on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the specified path of a POST request
existed, the newly generated DAG would have a root
of the specified path instead of only modifying the
data of the existing DAG at that path. These changes
modify behavior so that the entire tree structure
of the initially specified root CID is maintained,
and the only change is the Data at the specified path.
License: MIT
Signed-off-by: Tom O'Donnell todonnell@gmail.com