Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commands with progress bars #4139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbott
Copy link

@jbott jbott commented Aug 12, 2017

  • Show speed on ipfs get
  • Show a progress bar (with speed) on ipfs pin add

License: MIT
Signed-off-by: John Ott john@johnott.us

- Show speed on `ipfs get`
- Show a progress bar (with speed) on `ipfs pin add`

License: MIT
Signed-off-by: John Ott <john@johnott.us>
if err == nil {
stat, err := node.Stat()
if err == nil {
cnt = stat.LinksSize + stat.DataSize
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if this is correct. I tried using stat.BlockSize but that did not seem to include the DataSize measurement.

@jbott
Copy link
Author

jbott commented Aug 12, 2017

I'm not entirely sure how you guys would like these tests fixed. Looks like a failure due to the changed format of ipfs add --progress. It looks like test for ipfs get doesn't check the progress output?

@kevina
Copy link
Contributor

kevina commented Aug 14, 2017

Hi @jbott

I'm not entirely sure how you guys would like these tests fixed.

Could you be more specific here.

@jbott
Copy link
Author

jbott commented Aug 21, 2017

Oops, sorry I wasn't too explicit in what this patch was supposed to accomplish.

This adds size based progress bars to the ipfs pin add --progress command, along with enabling the show speed option on ipfs get.

The specific test that is failing is here: https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0085-pins.sh#L96

It's due to the change in the output format of the pin add with the --progress option. ipfs get has no corresponding test that matches this output format, and just choses to ignore checking the command's output (I believe).

If you guys have a preferred way of fixing this test (or alternatively just removing it), I would be happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants