Pinning fixes #4451
Merged
Pinning fixes #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Dec 4, 2017
Stebalien
commented
- Better allocation patterns
- Fix a very small race condition between GC and pinning.
- Fix Pin with ton of hashes won't start #4122 by resolving nodes as needed instead of up-front.
- Avoid creating many unnecessary contexts (also related to Pin with ton of hashes won't start #4122).
This came from an old commit that used a TODO context. Now that we have a real context, use that. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Otherwise, we could run a GC between adding and pinning. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Now that we add nodes to the DAG when pinning, don't bother adding them twice. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
instead of resolving all the pins first and then pinning, pin after resolving each pin. This: 1. Avoids storing all the nodes in memory. 2. Avoids not showing pin progress. fixes #4122 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
whyrusleeping
approved these changes
Dec 4, 2017
|
Hmm, I thought I sent out the CR (approve), looks like I did not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.