Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipfs v0.4.16-rc1 #5159

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Ipfs v0.4.16-rc1 #5159

merged 1 commit into from
Jun 28, 2018

Conversation

whyrusleeping
Copy link
Member

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@ghost ghost assigned whyrusleeping Jun 27, 2018
@ghost ghost added the status/in-progress In progress label Jun 27, 2018
## 0.4.16-rc1 2018-06-27
- Features
- Embed public keys inside ipns records, use for validation ([ipfs/go-ipfs#5079](https://github.com/ipfs/go-ipfs/pull/5079))
- Preload git plugin by default ([ipfs/go-ipfs#4991](https://github.com/ipfs/go-ipfs/pull/4991))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for the /p2p prefix?

- Features
- Embed public keys inside ipns records, use for validation ([ipfs/go-ipfs#5079](https://github.com/ipfs/go-ipfs/pull/5079))
- Preload git plugin by default ([ipfs/go-ipfs#4991](https://github.com/ipfs/go-ipfs/pull/4991))
- Improvements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorter TCP dial timeouts. This should yield a pretty bit improvement in some cases but may also cause problems (should call it out so that users are aware).

- Add package overview comments to coreapi ([ipfs/go-ipfs#5108](https://github.com/ipfs/go-ipfs/pull/5108))
- Add README to docs folder ([ipfs/go-ipfs#5095](https://github.com/ipfs/go-ipfs/pull/5095))
- Add system requirements to README ([ipfs/go-ipfs#5137](https://github.com/ipfs/go-ipfs/pull/5137))
- Bugfixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to note the DHT client fixes (libp2p/go-libp2p-kad-dht#166):

  • Don't route DHT traffic to client-only DHT nodes.
  • Do reply with peer info when we're directly connected to a peer, even if they're not in our routing table.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, are we including libp2p fixes?

@whyrusleeping
Copy link
Member Author

So this list is pulled from the list of merged PRs. I'm down to put more things in here if you think we should. Otherwise we can just talk about it in the notes.

@kevina
Copy link
Contributor

kevina commented Jun 27, 2018

@whyrusleeping I was kind of hopping we could get the migration to strict CIDs (see #4371 (comment) for checklist) done for this release so the user doesn't have to migrate the repo once again in the next release. (Most of the hard work should be done, I mainly need feedback. The migration code needs testing, but I have been dragging me feet on that as testing is a bit hard with out the target release for the migration.)

@whyrusleeping
Copy link
Member Author

@kevina we can just have another release out pretty quick. We need this release to ship as soon as possible, the longer we wait, the worse the DHT gets (due to an issue in the DHT in 0.4.15)

@kevina
Copy link
Contributor

kevina commented Jun 27, 2018

@whyrusleeping okay, that's your call. Unless I am missing something. the user will just have to migrate there repo once for this release and then again for the next, something I was hoping to avoid.

@whyrusleeping
Copy link
Member Author

yep. Would have been great to avoid that, but shipping these fixes is more important.

CHANGELOG.md Outdated
- Remove fuse platform build constraints ([ipfs/go-ipfs#5033](https://github.com/ipfs/go-ipfs/pull/5033))
- Warning when legacy NoSync setting is set ([ipfs/go-ipfs#5036](https://github.com/ipfs/go-ipfs/pull/5036))
- Clean up and refactor namesys module ([ipfs/go-ipfs#5007](https://github.com/ipfs/go-ipfs/pull/5007))
- Create a raw node instead of a file node when there is no content. ([ipfs/go-ipfs#4693](https://github.com/ipfs/go-ipfs/pull/4693))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of confusing. Maybe "When raw-leaves are enabled create an empty raw leaf instead of a protobuf node when there is no content"

@djdv
Copy link
Contributor

djdv commented Jun 27, 2018

I was hoping to sneak in #4956, but I'm okay with punting that to the next release if DHT is in need.

@Stebalien
Copy link
Member

@kevina so, the CID fixes will be rather wide-reaching and I have a feeling that'll take a while to review, test, bake, and deem ready. I'd like to minimize migrations but, well, I think we'll have to get used to running them pretty frequently anyways. Really, we should focus on making them easier to run.

@Stebalien
Copy link
Member

@djdv

I was hoping to sneak in #4956, but I'm okay with punting that to the next release if DHT is in need.

I've taken a look at that patch and it looks good to me. However, IIRC, you were thinking about erroring out by default? We should probably come to a decision on that before merging.

Also, I'd like to be smarter about file versus directory symlinks if possible.

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just ship this. We can write full release notes when we release.

@whyrusleeping
Copy link
Member Author

Let's just ship this. We can write full release notes when we release.

A man after my own heart <3

@whyrusleeping whyrusleeping deleted the release-0.4.16-rc1 branch June 28, 2018 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants