RFC: make GC codec agnostic #5347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that GC will work regardless of the codec on the CIDs returned by the blockstore. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned
Stebalien
commented
Aug 6, 2018
| @@ -76,14 +76,16 @@ func GC(ctx context.Context, bs bstore.GCBlockstore, dstor dstore.Datastore, pn | |||
| errors := false | |||
| var removed uint64 | |||
|
|
|||
| gchashes := MultihashSetFromCids(gcs) | |||
There was a problem hiding this comment.
Note: we can't just use a multihash set when generating the colored set as we might visit a node with a raw CID first and then not visit its children when we visit it using a non-raw CID. Basically, traversal cares about CIDs.
|
Note this p.r. depends on a codec agnostic blockstore. Or part of #5231. |
|
As @kevina pointed out, this also doesn't fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that GC will work regardless of the codec on the CIDs returned by the blockstore.