-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce first strategic provider: do nothing #6292
Conversation
9012d64
to
9a17914
Compare
9a17914
to
992ecb4
Compare
992ecb4
to
9112b91
Compare
9112b91
to
cb92db3
Compare
@scout I think you'll find this PR useful. You mentioned to me not long ago that you'd like the ability to disable providing in IPFS without disabling content routing. This PR does exactly that. A series of upcoming PRs will flesh out the provider system further, but the ability to disable providing without disabling content routing itself will be preserved. Is this something you can put to use right away? In its current form you'd need to set an experimental flag and restart the daemon. Will that work for what you have in mind? |
Thanks very much @michaelavila ! This will help a ton with debugging and observing bona-fide gateway traffic and save us some bandwidth costs to boot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to document some conventions used in the constructor after the refactors are done, the rest generally looks good.
(also, more smaller commits would make reviewing easier) |
e967e08
to
b47b4aa
Compare
5cf93f4
to
0a4beb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (sorry for the delay, it somehow fell off my radar)
@magik6k no worries, thanks for following up! |
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
0a4beb0
to
065d783
Compare
🚀 |
These commits introduce an experimental provider system that, currently, does not provide. Functionality will be layered on to the experimental provider until it has all of the behavior needed to replace the default provider system.
The experimental system can be enabled by issuing the following command:
ipfs config Experimental.StrategicProviding true
Then you must restart your daemon.