Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to base32 by default for CIDv1 #6300

Merged
merged 2 commits into from
May 13, 2019
Merged

switch to base32 by default for CIDv1 #6300

merged 2 commits into from
May 13, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented May 6, 2019 •
edited
Loading

@ghost ghost assigned Stebalien May 6, 2019
@ghost ghost added the status/in-progress In progress label May 6, 2019
@Stebalien
Copy link
Member Author

We'll probably need to fix a bunch of tests.

@Stebalien
Copy link
Member Author

Stebalien commented May 7, 2019 •
edited
Loading

Perl is stupidly powerful.

perl -i -e 'sub base32 { my ($cid) = @_; my $res=`ipfs cid base32 $cid`; chomp $res; return $res; }' -pe 's/\b(z[a-zA-Z0-9]{10,})/"@{[base32($1)]}"/ge' **/*

(mostly works)

@Stebalien Stebalien force-pushed the feat/cidv1-default-base32 branch 3 times, most recently from 9660fa6 to 575e635 Compare May 7, 2019 09:04
@magik6k magik6k mentioned this pull request May 8, 2019
Closed
@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label May 8, 2019
@Stebalien
switch to base32 by default for CIDv1
9886fc0 
fixes #6220

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
dep: update ipld formats
598f1fa 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien marked this pull request as ready for review May 13, 2019 18:28
@Stebalien Stebalien removed the status/blocked Unable to be worked further until needs are met label May 13, 2019
@Stebalien Stebalien merged commit 5b8bfc2 into master May 13, 2019
@Stebalien Stebalien deleted the feat/cidv1-default-base32 branch May 13, 2019 21:02
@Stebalien Stebalien restored the feat/cidv1-default-base32 branch May 30, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees

@Stebalien Stebalien

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch CIDv1 from Base58 to Base32 (go-ipfs)
2 participants
@Stebalien @magik6k