plugins: support Close() for Tracer plugins as well #6672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is unrelated. |
Stebalien
requested changes
Sep 24, 2019
plugin/tracer.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
|
|
|||
| // PluginTracer is an interface that can be implemented to add a tracer | |||
| type PluginTracer interface { | |||
| Plugin | |||
| Closer | |||
There was a problem hiding this comment.
I wouldn't force tracers to have a close method.
plugin/loader/loader.go
Outdated
| @@ -266,7 +266,7 @@ func (loader *PluginLoader) Close() error { | |||
| started := loader.started | |||
| loader.started = nil | |||
| for _, pl := range started { | |||
| if pl, ok := pl.(plugin.PluginDaemon); ok { | |||
| if pl, ok := pl.(plugin.Closer); ok { | |||
There was a problem hiding this comment.
plugin.Closer feels a bit overkill. What about just type-asserting pl.(io.Closer)?
There was a problem hiding this comment.
I'm ok with that if you are, I just though the semantic was a bit off (it's not really an I/O).
There was a problem hiding this comment.
io.Closer is really just the standard "closer" at this point.
Most of the tracers available need to properly close to send the remaining traces before the process exit.
MichaelMure
force-pushed
the
plugin-tracer-close
branch
from
92ae72f
to
72026b8
Compare
|
Fixed as your were suggesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tracers available need to properly close to send the remaining traces before the process exit.