Revert Go trimpath #7665
Merged
Revert Go trimpath #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 480defa.
aschmahmann
commented
Sep 9, 2020
Comment on lines
13
to
+15
| # Override so we can combine with the user's go flags. | ||
| override GOFLAGS += -trimpath | ||
| # Try to make building as reproducible as possible by stripping the go path. | ||
| override GOFLAGS += "-asmflags=all='-trimpath=$(GOPATH)'" "-gcflags=all='-trimpath=$(GOPATH)'" |
There was a problem hiding this comment.
We could also just remove these 3 lines entirely and not worry about reproducible builds that aren't using our dist build script from https://github.com/ipfs/distributions. At some point we could add in some make flag like make build-reproducible that uses the dist build script.
However, leaving this in and keeping behavior the same seems reasonable for now.
Stebalien
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.