unixfs autosharding with config #8527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
aschmahmann
force-pushed
the
feat/unixfs-autosharding-with-config
branch
from
da36d77
to
e51a8dd
Compare
schomatis
force-pushed
the
feat/unixfs-autosharding-with-config
branch
from
c2925e2
to
9a0c4a5
Compare
aschmahmann
force-pushed
the
feat/unixfs-autosharding-with-config
branch
from
9a0c4a5
to
fd55804
Compare
aschmahmann
commented
Nov 16, 2021
| @@ -216,7 +216,7 @@ jobs: | |||
| command: | | |||
| npm init -y | |||
| npm install ipfs@^0.59.1 | |||
| npm install ipfs-interop@^7.0.3 | |||
There was a problem hiding this comment.
TODO: use a version of interop that's on master
aschmahmann
commented
Nov 16, 2021
aschmahmann
commented
Nov 16, 2021
aschmahmann
commented
Nov 16, 2021
- applies fix from go-ipfs-config which removes null when default - escapes JSON string when passed in sharness script
* test: add tests for automatic sharding and unsharding * refactor: changed some naming in the sharding sharness tests to make more sense Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
aschmahmann
force-pushed
the
feat/unixfs-autosharding-with-config
branch
from
893e6a9
to
e0b6bb4
Compare
lidel
added a commit
to ipfs/go-ipfs-config
that referenced
this pull request
Nov 23, 2021
We switch to autosharding setup in ipfs/kubo#8527
This ensures existing users of global sharding experiment get notified that the flag no longer works + that autosharding happens automatically. For people who NEED to keep the old behavior (eg. have no time to migrate today) there is a note about restoring it with `UnixFSShardingSizeThreshold`.
lidel
reviewed
Nov 23, 2021
Comment on lines
+329
to
+334
| // Migrate users of deprecated Experimental.ShardingEnabled flag | ||
| if cfg.Experimental.ShardingEnabled { | ||
| logger.Fatal("The `Experimental.ShardingEnabled` field is no longer used, please remove it from the config.\n" + | ||
| "go-ipfs now automatically shards when directory block is bigger than `" + shardSizeString + "`.\n" + | ||
| "If you need to restore the old behavior (sharding everything) set `Internal.UnixFSShardingSizeThreshold` to `1B`.\n") | ||
| } |
There was a problem hiding this comment.
ℹ️ This provides a migration path for existing users that have experiment enabled.
I also updated docs/experimental-features.md and made flag optional in JSON in ipfs/go-ipfs-config#158
There was a problem hiding this comment.
Thanks. This seems like the best we can get.
There's no way to warn anybody who explicitly wanted sharding to stay off since that flag didn't have no way to denote "unset" which is what we're moving towards now.
lidel
added a commit
to ipfs/go-ipfs-config
that referenced
this pull request
Nov 23, 2021
We switch to autosharding setup in ipfs/kubo#8527
|
Continued in #8563 |
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
We switch to autosharding setup in ipfs#8527
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
We switch to autosharding setup in ipfs#8527
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
We switch to autosharding setup in ipfs#8527
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
We switch to autosharding setup in ipfs#8527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8114 and may end up merging onto it.
ipfs/go-ipfs-config#149 adds
Internal.UnixFSShardingSizeThresholdconfig flagTesting:
Experimental.ShardingEnabled?