Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #8548

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix typos #8548

merged 1 commit into from
Nov 17, 2021

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Nov 12, 2021

No description provided.

lidel
lidel approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@lidel
Copy link
Member

lidel commented Nov 16, 2021

@aschmahmann does gotest always fail like this on PRs from forks?

@aschmahmann
Copy link
Contributor

aschmahmann commented Nov 17, 2021 •
edited
Loading

@lidel this should be fixed by #8554. I'll cherry-pick from that PR to make sure it works, if it does then I'll merge the other one to master and reset + merge this one

@aschmahmann aschmahmann enabled auto-merge (squash) November 17, 2021 19:58
@aschmahmann aschmahmann merged commit 0c2f9d5 into ipfs:master Nov 17, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rex4539 @lidel @aschmahmann @Stebalien