-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t0060: reactivate daemon tests #896
Conversation
On Travis there is the following error:
On my Linux machine I get a line like:
but it looks like on Travis there is no such line printed... |
It should definitely show up. Maybe it's not waiting the full amount of time-- It's also possible this is the same problem that was plaguing me with my approach to waiting for the daemon (before @cryptix's pollEndpoint saved the day) -- which would be a bug. the daemon must output the API line. If we don't suss out the problem quickly, it may not be worth worrying about-- we can maybe mark that line as a known breakage in sharness -- as we hope to rewrite how the daemon spins up in the next few weeks. |
Ok, I will resend with test_expect_failure for this test. Thanks! |
Tests in this script had been deactivated because there was no good way to wait until the daemon was ready. Now that we can use pollEndpoint for that it's time to reactivate the tests. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
b998b74
to
37bfef8
Compare
Resent with one test_expect_failure. The Jenkins network-test failed but it is not related. |
the network test passed ( |
This is a solution to issue #886 (Fix or discard t0060-daemon.sh?)
Tests in this script had been deactivated because
there was no good way to wait until the daemon was
ready. Now that we can use pollEndpoint for that
it's time to reactivate the tests.
License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org