Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pin.depth and add meta examples #19

Merged
merged 7 commits into from
Jul 13, 2020
Merged

Remove Pin.depth and add meta examples #19

merged 7 commits into from
Jul 13, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 13, 2020 •
edited
Loading

This PR

cc @obo20 @achingbrain

@lidel lidel changed the title Move depth to optional meta attributes Move Pin.depth to optional Pin.meta attributes Jul 13, 2020
@lidel lidel mentioned this pull request Jul 13, 2020
Closed
@lidel lidel added this to the MVP for WebUI Integration milestone Jul 13, 2020
jacobheun
jacobheun reviewed Jul 13, 2020
View reviewed changes
ipfs-pinning-service.yaml Outdated Show resolved Hide resolved
ipfs-pinning-service.yaml Outdated Show resolved Hide resolved
@lidel lidel mentioned this pull request Jul 13, 2020
Closed
@lidel lidel changed the title Move Pin.depth to optional Pin.meta attributes Remove Pin.depth and add meta examples Jul 13, 2020
@lidel
Copy link
Member Author

lidel commented Jul 13, 2020 •
edited
Loading

Thank you for feedback!

  • I applied clarifications/suggestions
  • Opened Mandatory provider hints #22 to discuss promotion of peering hints to mandatory fields
  • Merging this to remove depth from shared spec – feel free to follow-up in new issues / PRs

@lidel lidel merged commit b32fff0 into master Jul 13, 2020
@lidel lidel deleted the move-depth-to-meta branch July 13, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun left review comments

@achingbrain achingbrain achingbrain left review comments

@aschmahmann aschmahmann aschmahmann left review comments

@obo20 obo20 obo20 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP for WebUI Integration
Development

Successfully merging this pull request may close these issues.

Networking difficulties while pinning data
5 participants
@lidel @jacobheun @achingbrain @aschmahmann @obo20