disable providing of content in Bitswap #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
commented
Oct 20, 2021
Comment on lines
+173
to
+175
| // TODO: Ideally we could configure bitswap to not serve content over bitswap. | ||
| // The gateway's job is not to serve content over libp2p, just http. | ||
| // Perhaps we're willing to respond to requests from other gateways in a cluster. |
There was a problem hiding this comment.
@whyrusleeping WDYT? There are advantages to serving libp2p content here (e.g. so that all gateways behind a single HTTP endpoint behave similarly and share caches), but it could also not be worth the bother or confusion to do so.
There was a problem hiding this comment.
Yeah, I'm not really sure what the right way forward here is yet. I think we might want to do something like have the gateways be stateless and just peer to a common cluster node? this particular thing is worth discussing more broadly, but is also outside the scope of the PR here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code edited in GH browser. Should run
go buildbefore merging 😄. Update: it builds.