feat!: independent dht and routing v1 flags #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Name of the flag was inconsistent with the rest of the documentation and environmental variable. Likely typo.
… list Just use the provided StringsSlice instead of writing our own method for comma-separated list options. This also allows users to simply pass the flag multiple times with the different values.
hacdias
force-pushed
the
feat/accelerated-dht-flag
branch
from
5acdfbb
to
2a02d63
Compare
hacdias
changed the title
2 tasks
lidel
approved these changes
Apr 9, 2024
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #111. Does the following:
dht-routingflag. Can beaccelerated,standardoroff. This is personally useful for me locally to disable the accelerated DHT.routingwithrouting-v1-endpointswhich supports more than one endpoint. Default is cid.contact.In the process, I also fixed the typo in the flag
dht-shared-host, and cleaned up the comma-separated flags to useStringsSlice.