-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest files for unixfs loaded via HTTP Gateway #257
Comments
Related are notes from the 2021-11-16 IPFS operators meeting: https://hackmd.io/MiYYUCR-RWqhAKfJ_B15wA |
Hi @lidel. I started working at Fission this year and have recently been tasked with implementing redirects support in go-ipfs. @cbrake started working on this in this PR 🙏 and I plan on continuing the work in this PR. If you don't mind, I'd like to make sure I understand the process here as far as specs and issue management go so I don't cause any annoying friction. From the issues I've read through it appears that it was decided to split out redirects support from manifests support when Cloudflare announced Cloudflare Pages with Regardless of whether or not manifests and redirects are separate specs, my assumption is that the redirects portion of the spec will both inform and be informed by the go-ipfs redirects support tentative implementation. Does that sound right? Is there any preferred order to tackling this (spec vs implementation first)? I'm currently assuming I should start with essentially implementing what Cloudflare supports and see what feedback others provide, adjust for feedback, and then eventually work backward from there into text for the spec. Assuming I'm on the right track, I was planning on submitting 1) an issue in go-ipfs to track this implementation work vs just my draft PR, and 2) possibly an issue in this specs repo to track the redirects portion of the spec, unless it should all be included in this spec issue. Thank you in advance for any feedback and guidance. If you have any other tips on the code base or any plans you had for how the code should be reorged (I see you've been doing some refactoring recently) I'd love to hear them. Thank you! 🙏 |
Hi @justincjohnson. Thanks for reaching out here. @lidel is great at seeing GitHub notifications and processing them. I don't know how many others are though. If you don't get a response in the next day or so, feel free to start a thread in #ipfs-operators in FIL Slack or #ipfs-dev in IPFS Discord. |
Hi @justincjohnson, really appreciate reaching out! I believe tldr from the prior discussions is that we translated requirements into two sibling features that will improve the devexp around unixfs website hosting using IPFS gateway:
Feel free to work on both, but focusing on
Yes, this plan sounds good. There are caveats around both headers and redirects that we will fully understand while writing sharness tests for them, so specs may change multiple times before we finish the mvp implementation. It is fine to keep discussion around go-ipfs PR and wait with specs until the dust settles.
We have various gateway improvements in flight, so it is better to have separate specs for now. ps. I left some quick comments in ipfs/kubo#8816 |
Fabulous! Thanks for the guidance @lidel. I'll get started. |
For the benefit of anyone coming here looking for information on redirects support, see ipfs/kubo#8890. |
@lidel a User defined headers
This would greatly improve the functionality of static dWebsites delivered locally, or through a gateway. Gateway operator defined headersThere are many more, but this is a good starting point. These should not be configurable by the end user as they can globally impact the operation and quality of the service.
|
Thank you, useful feedback. To get this moving froward, we could start with a safelist of allowed headers. For next steps here, interested parties could
If anyone is interested in kicking this off and providing implementation and specs, I am willing to lend necessary review time. 👍 |
This is a placeholder issue for creating a spec for "content root's manifest files" which would be part of the data published on IPFS (eg.
/ipfs/CID/_something
or/ipfs/CID/.well-known/ipfs/foo
) that provides hints to HTTP Gateway around things like redirects, content types and custom HTTP headers.Related reading:
Possible reuse of:
_redirects
(prior art in netlify docs_headers
file (prior art in netlify docs and cloudflare docs)Feel free to discuss/post ideas below, or open PRs with IPIP drafts that could be reviewed independently.
The text was updated successfully, but these errors were encountered: