Improve EOF handling #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 51.03% 50.20% -0.84%
==========================================
Files 3 3
Lines 241 245 +4
==========================================
Hits 123 123
- Misses 83 87 +4
Partials 35 35
Continue to review full report at Codecov.
|
mvdan
approved these changes
Nov 5, 2020
|
thanks @mvdan, on the topic of bytes as strings: I prefer hex for for this kind of thing simply for its portability, this string for instance is straight out of JavaScript. Base64 tends to involve more dependencies and hoop-jumping in various languages, while hex is usually lowest-common-denominator |
masih
added a commit
that referenced
this pull request
Jul 15, 2021
Remove dependency to `bufio.Reader` in internal `carv1` package that seems to be mainly used for peeking a byte to return appropriate error when stream abruptly ends, relating to #36. This allows simplification of code across the repo and remove all unnecessary wrappings of `io.Reader` with `bufio.Reader`. This will also aid simplify the internal IO utilities which will be done in future PRs. For now we simply remove dependency to `bufio.Reader` See: - #36
mvdan
pushed a commit
that referenced
this pull request
Jul 16, 2021
Remove dependency to `bufio.Reader` in internal `carv1` package that seems to be mainly used for peeking a byte to return appropriate error when stream abruptly ends, relating to #36. This allows simplification of code across the repo and remove all unnecessary wrappings of `io.Reader` with `bufio.Reader`. This will also aid simplify the internal IO utilities which will be done in future PRs. For now we simply remove dependency to `bufio.Reader` See: - #36
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 22, 2023
Remove dependency to `bufio.Reader` in internal `carv1` package that seems to be mainly used for peeking a byte to return appropriate error when stream abruptly ends, relating to #36. This allows simplification of code across the repo and remove all unnecessary wrappings of `io.Reader` with `bufio.Reader`. This will also aid simplify the internal IO utilities which will be done in future PRs. For now we simply remove dependency to `bufio.Reader` See: - ipld/go-car#36 This commit was moved from ipld/go-car@cc1e449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up from go-ipfs folks trying to import a CAR file that was truncated but they had no indication that it was. The final block had an
0xa0after it, which is an improper varint, soReadUvarint()was returning anio.EOFwhich also happens if there's no next block at all and is therefore the proper-EOF signal. This change lifts the proper-EOF case out into aPeek(1)so every other EOF from there on can be assumed to be unexpected.