Custom plugin to collect topology data for use by scripts #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeroen van Bemmel <jeroen.van_bemmel@nokia.com>
…essions (fixes ipspace#460) There are devices that need IPv6 enabled on an interface to make unnumbered EBGP sessions work. Those devices might not be able to pass the IPv4-only unnumbered EBGP test case because IPv6 is not enabled. This commit adds 'ipv6: True' to interfaces that have at least one unnumbered EBGP session. The change is made very late in the transformation process (after the links module calculates the node address families) and thus should not impact other routing protocols. It does not impact other modules using address families (like VRF module). An alternative might have been to add yet another flag (example: ipv6_lla) but that would require changes in initial device configuration templates.
ipspace
force-pushed
the
dev
branch
2 times, most recently
from
8bb6f28
to
3aac94e
Compare
ipspace
force-pushed
the
dev
branch
3 times, most recently
from
5b43a8f
to
001e946
Compare
|
Revisiting this old idea: what if we have a setting that would specify what needs to be copied into Ansible 'all' group under 'system' dictionary and use that setting when creating Ansible inventory? You could then use the 'combine' filter in Jinja2 templates if you want to have a merged view of local and system VLANs (for example), or just peek into system settings if you're so inclined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #482
For users that need topology information as input to per-node configuration scripts, in cases where this information is not 'naturally' included by the core modules.
One use case is generation of custom bgp policies with prefix filters that are configured for remote vlans (on other nodes), or communities for vrfs that are not locally present