Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate and work on skipped tests #21

Closed
riley-harper opened this issue Aug 2, 2022 · 0 comments · Fixed by #139
Closed

Evaluate and work on skipped tests #21

riley-harper opened this issue Aug 2, 2022 · 0 comments · Fixed by #139
Labels
tests Unit and integration tests for code

Comments

@riley-harper
Copy link
Contributor

There are 4 skipped tests at the time of writing. Let's evaluate why they're skipped and see if we can fix them up and get them to run.
@riley-harper riley-harper added the tests Unit and integration tests for code label Aug 2, 2022
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Remove a skipped model_exploration step 3 test
db68660 
model_exploration_test.test_step_3_get_feature_importances_random_forest is
covered by tests for training step 3 in training_test.py.
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Rewrite a skipped model exploration test
0ddb4c3 
This tests Training step 3 with a probit model instead of a random forest
model. Probit models save coefficients, not feature importances.
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Remove unexecuted debug code in a main_loop test
94783ac
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Rewrite a skipped matching aggregate features test
d273ec3 
This required some heavy refactoring. I think that this test was really old.
The new checks are very similar to the checks in the old test.
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Rename two tests that referenced the wrong matching step
b87ed91
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Remove a skipped matching secondary_threshold test
1b69d54 
Reading the comment at the top of this test, I went looking for something that
directly replaced the "secondary_threshold" matching attribute. I couldn't find
anything that looked closely related. So let's just remove this test.
riley-harper added a commit that referenced this issue Jun 18, 2024
@riley-harper
[#21] Fix two flake8 import errors
9766d6e
@riley-harper riley-harper mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Unit and integration tests for code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unskip several skipped tests ipums/hlink
1 participant
@riley-harper