Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the Sphinx version in setup.py #23

Closed
riley-harper opened this issue Aug 2, 2022 · 0 comments · Fixed by #68
Closed

Pin the Sphinx version in setup.py #23

riley-harper opened this issue Aug 2, 2022 · 0 comments · Fixed by #68
Milestone

Comments

@riley-harper
Copy link
Contributor

Generating the documentation with different versions of Sphinx can cause lots of changes to the html pages. Let's pin the version of Sphinx that's installed with hlink to reduce the number of issues with developers generating the documentation with differing versions of Sphinx. It looks like the most recent Sphinx version is 5.1.1.

@riley-harper riley-harper self-assigned this Aug 2, 2022
riley-harper added a commit that referenced this issue Dec 6, 2022
This pins production dependencies to a minor version instead of a patch
version. These dependencies can now silently be upgraded from 1.1.0 -> 1.1.3,
for example. Upgrades that increment the minor or major version will still
require manual changes. These packages are all fairly stable, and so we
don't expect these bug fix patches to affect hlink's behavior significantly.
This has the side effect of upgrading Spark to 3.3.1 and completing #61.

Development dependencies are pinned on a more ad-hoc basis. Some like black
and pre-commit can be pinned quite loosely. Others like Sphinx and pytest we
would like to keep more strictly pinned. This commit also completes #23 by
pinning Sphinx.
@riley-harper riley-harper added this to the v3.3.0 milestone Dec 6, 2022
@riley-harper riley-harper removed their assignment Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant