Adjust dependency version specification #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pins production dependencies to a minor version instead of a patch version. These dependencies can now silently be upgraded from 1.1.0 -> 1.1.3, for example. Upgrades that increment the minor or major version will still require manual changes. These packages are all fairly stable, and so we don't expect these bug fix patches to affect hlink's behavior significantly. This has the side effect of upgrading Spark to 3.3.1 and completing #61. Development dependencies are pinned on a more ad-hoc basis. Some like black and pre-commit can be pinned quite loosely. Others like Sphinx and pytest we would like to keep more strictly pinned. This commit also completes #23 by pinning Sphinx.
This avoids pinning Python to a particular bug fix / patch version and instead allows testing on any Python 3.10.X release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58 by loosening and adjusting dependency specifications.
Closes #61 by upgrading Spark from 3.3.0 to 3.3.1.
Closes #23 by strictly pinning the version of Sphinx in the development dependencies.
This pull request adjusts how we specify dependency versions in setup.py. Instead of pinning to an exact version for production dependencies, we now specify a major and minor version and allow the patch version to vary. So dependencies may be silently upgraded from version 1.1.0 -> 1.1.3, for example. Updates to minor or major versions will still require a manual update. This uses the
~="compatible version" syntax for Python packaging.The development dependencies are pinned on a more case-by-case basis. We want to keep Sphinx pinned to a particular version because the version is output in the documentation, so using different versions can cause the documentation to update unexpectedly. black and flake8 can vary more widely. They are both pretty stable, and I don't think we'll run into many issues with the current version specifications. Similarly for twine and pre-commit.
This also updates the Dockerfile, specifying the image as
python:3.10instead ofpython:3.10.4. This pulls in the latest version of Python 3.10 instead of 3.10.4. The latest version at the moment is 3.10.8.