Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less Anyhow, More ThisError for library crates #62

Closed
2 tasks
zeeshanlakhani opened this issue Feb 28, 2023 · 0 comments · Fixed by #139
Closed
2 tasks

Less Anyhow, More ThisError for library crates #62

zeeshanlakhani opened this issue Feb 28, 2023 · 0 comments · Fixed by #139
Labels
good first issue Good for newcomers

Comments

@zeeshanlakhani
Copy link
Contributor

zeeshanlakhani commented Feb 28, 2023 •
edited
Loading

Summary

Runtime should rely on anyhow, but the library packages (e.g. core, wasm), should leverage only thiserror, with specific error information and names.

Checklist

  • homestar-core
  • homestar-wasm
@zeeshanlakhani zeeshanlakhani added enhancement New feature or request and removed enhancement New feature or request labels Feb 28, 2023
@zeeshanlakhani zeeshanlakhani changed the title Less Anyhow, More ThisError Less Anyhow, More ThisError for library crates Feb 28, 2023
@zeeshanlakhani zeeshanlakhani added this to the MVP Development - Q2 2023 milestone Mar 21, 2023
@zeeshanlakhani zeeshanlakhani added the good first issue Good for newcomers label Jun 1, 2023
zeeshanlakhani added a commit that referenced this issue Jun 14, 2023
@zeeshanlakhani
refactor: error handling with thiserror, anyhow for runtime only
706ca25 
Closes #62

This PR includes:

* flake commands for helpful shortcuts
* move to cargo nextest
* worker tests
* addition of workspace macros bail and ensure for internal error handling
* moves general workflow structure to homestar-core, with generic handling, and
  allows for further building blocks
@zeeshanlakhani zeeshanlakhani mentioned this issue Jun 14, 2023
Merged
zeeshanlakhani pushed a commit that referenced this issue Jun 14, 2023
refactor: error handling with thiserror, anyhow for runtime only (#139)
1635ffa 
Closes #62

This PR includes:

* flake commands for helpful shortcuts
* move to cargo nextest
* worker tests
* addition of workspace macros bail and ensure for internal error
handling
* moves general workflow structure to homestar-core, with generic
handling, and allows for further building blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: error handling with thiserror, anyhow for runtime only ipvm-wg/homestar
1 participant
@zeeshanlakhani