Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some extension now need events #84

Closed
Carreau opened this issue Jul 21, 2014 · 6 comments
Closed

Some extension now need events #84

Carreau opened this issue Jul 21, 2014 · 6 comments
Assignees

Comments

@Carreau
Copy link
Member

Carreau commented Jul 21, 2014

in particular SWC and init_cell need to be passed "base/js/events" and the call to register_preset updated. assigning me.

@Carreau Carreau self-assigned this Jul 21, 2014
@juhasch
Copy link
Member

juhasch commented Jul 21, 2014

Basically we now have three generations of nb extensions.

  • 1.x
  • 2.x + 3.x before require.js,
  • 3.x after require.js
    OK, we don't need to care too much for 1.x anymore I think, so only two.

Do you have a suggestion how to handle the different versions ?
We at least need to update the descriptions, have different custom.js examples and some extensions will need to be updated. Simply ignore anything before require.js was merged and only caring for the new stuff seems pretty drastic.

@damianavila
Copy link
Member

We need to provide at least support for before and after require.js, I agree that 1.x is getting old quickly, and it will be more quickly as long as the 3x and 4x see the light...

@Carreau
Copy link
Member Author

Carreau commented Jul 22, 2014

There are still some fixes on their way for 3.0 that would make most extension of 2.0 work with 3.0.
We will do a compatibility layer (at least for notebooks formats) on 2.x, so I guess we can add soem shim on 2.x that simplify the sharing of extensions between 2.x and 3.x

@damianavila
Copy link
Member

Seems reasonable...

@juhasch
Copy link
Member

juhasch commented Jul 22, 2014

Sounds good. I'll look at the other extensions in usability, once ipython/ipython#6119 is merged.

@juhasch
Copy link
Member

juhasch commented Jan 25, 2015

I think we can close this now. All active notebook extensions for 3.x have been updated or do not work anymore anyway.

@juhasch juhasch closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants