Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html embed exporter #753

Merged
merged 9 commits into from
Oct 5, 2016
Merged

Conversation

juhasch
Copy link
Member

@juhasch juhasch commented Oct 1, 2016

  • Add an exporter for embedding graphics in HTML nbconvert output
  • Update documentation on exporters
  • Add link to documentation in README.md

@jcb91
Copy link
Member

jcb91 commented Oct 3, 2016

I'm not sure why codecov seems to have decided to add statuses to PRs again, I thought it was disabled 😦

@jcb91
Copy link
Member

jcb91 commented Oct 3, 2016

but anyway, I think it's complaining because your new exporter isn't tested to the extent of the rest of the codebase.

@jfbercher
Copy link
Member

The new exporter embedding linked images is certainly a good idea.

@juhasch
Copy link
Member Author

juhasch commented Oct 3, 2016

@jcb91: True, a test is still missing. I will add one before merging.
@jfbercher: It would be nicer to have entrypoints for postprocessors, so one could add a --embed flag or so. But for now I think this is the best option.

@juhasch juhasch merged commit c11a4a0 into ipython-contrib:master Oct 5, 2016
@juhasch juhasch deleted the html_embed_exporter branch October 5, 2016 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants