Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank ipykernel 6.18.2 ? #1040

Closed
maartenbreddels opened this issue Nov 29, 2022 · 7 comments · Fixed by #1042
Closed

Yank ipykernel 6.18.2 ? #1040

maartenbreddels opened this issue Nov 29, 2022 · 7 comments · Fixed by #1042
Labels

Comments

@maartenbreddels
Copy link
Contributor

Seems like this release also breaks stuff, ipywidget CI doesn't run:

jdaviz (ipywidget based) is completely broken:

I'm looking into it, but better to avoid many unhappy users.

@blink1073
Copy link
Contributor

Yanked. We'll have to add ipywidgets to our downstream tests before attempting another release.

@blink1073 blink1073 added the bug label Nov 29, 2022
@maartenbreddels
Copy link
Contributor Author

maartenbreddels commented Nov 29, 2022 via email

@pllim
Copy link

pllim commented Nov 29, 2022

For the record, for jdaviz, we saw "no such comm" errors, which are probably related to #973 ?

@maartenbreddels
Copy link
Contributor Author

correct

blink1073 pushed a commit that referenced this issue Nov 29, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
Fixes #1040
@jasongrout
Copy link
Member

When I try using ipykernel 6.18.3 with current ipywidgets in jupyterlab, I get a lot of "No such comm: ..." messages whenever I try to manipulate a widget (sounds like the same thing as @pllim was mentioning above). Was ipykernel 6.18.3 supposed to fix these messages?

@jasongrout
Copy link
Member

Ah, I see now that 6.18.3 was yanked on pypi. I was still seeing errors installing from conda-forge, since 6.18.1 and 6.18.2 are still up there. conda-forge/admin-requests#520 marks these as broken.

@blink1073
Copy link
Contributor

We added ipywidgets as a downstream test in #1042, but the test suite apparently does not capture dynamic widget messages. In #1043 (comment) I recommended that we back out these changes to comm altogether. Another path is to add testing in ipywidgets that would have covered this case, and make sure those tests pass before attempting another ipykernel release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants