Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change registration of the qt eventloop after a similar change in IPython #293

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jan 3, 2018

It took me several hours to figure this one out!! After ipython/ipython#10756, you can't run %matplotlib qt5 in any Jupyter client that uses ipykernel because it's broken.

This was reported in spyder-ide/spyder#6091 and I created spyder-ide/spyder#6121 to deal with this problem in our side.

@ccordoba12
Copy link
Member Author

The test errors don't seem related to my work.

@takluyver
Copy link
Member

I agree that the failures are not related to this. I've just rerun the tests on master and got the same failure. I'm investigating, but I don't have long today to look at it, so feel free to look into it as well.

@takluyver
Copy link
Member

It looks like the error occurs with tornado 5.0a1. @minrk, you've been making fixes related to that - any ideas?

________________________________ test_asyncio_interrupt ________________________________

args = (), kwargs = {}

    def skipper_func(*args, **kwargs):
        """Skipper for normal test functions."""
        if skip_val():
            raise nose.SkipTest(get_msg(f,msg))
        else:
>           return f(*args, **kwargs)

../../.local/lib/python3.6/site-packages/IPython/testing/decorators.py:212: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../.local/lib/python3.6/site-packages/ipykernel/tests/test_eventloop.py:43: in test_asyncio_interrupt
    msg_id, content = execute(async_code, KC)
../../.local/lib/python3.6/site-packages/ipykernel/tests/utils.py:66: in execute
    reply = kc.get_shell_msg(timeout=TIMEOUT)
../../.local/lib/python3.6/site-packages/jupyter_client/client.py:77: in get_shell_msg
    return self.shell_channel.get_msg(*args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <jupyter_client.blocking.channels.ZMQSocketChannel object at 0x7fd0699d87b8>
block = True, timeout = 15000

    def get_msg(self, block=True, timeout=None):
        """ Gets a message if there is one that is ready. """
        if block:
            if timeout is not None:
                timeout *= 1000  # seconds to ms
            ready = self.socket.poll(timeout)
        else:
            ready = self.socket.poll(timeout=0)
    
        if ready:
            return self._recv()
        else:
>           raise Empty
E           queue.Empty

@minrk
Copy link
Member

minrk commented Jan 5, 2018

I opened #294 to pin tornado for tests while we work it out.

This PR should be OK

@ccordoba12
Copy link
Member Author

Thanks Min!

@takluyver
Copy link
Member

Reopening to rerun tests.

@takluyver takluyver closed this Jan 6, 2018
@takluyver takluyver reopened this Jan 6, 2018
@takluyver takluyver merged commit 3b6d089 into ipython:master Jan 8, 2018
@ccordoba12 ccordoba12 deleted the patch-1 branch January 11, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants