Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set closed flag #435

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Set closed flag #435

merged 1 commit into from
Sep 15, 2019

Conversation

impact27
Copy link
Contributor

Avoid an issue where the comm sends close messages after being closed.

@ccordoba12
Copy link
Member

@impact27, is this still needed after PR #433?

@ccordoba12 ccordoba12 mentioned this pull request Sep 14, 2019
Merged
@impact27
Copy link
Contributor Author

#433 fixes this problem when called from __del__. This would prevent the same problem from happening if the comm is closed in the closing callback.

@blink1073 blink1073 closed this Sep 15, 2019
@blink1073 blink1073 reopened this Sep 15, 2019
@blink1073 blink1073 closed this Sep 15, 2019
@blink1073 blink1073 reopened this Sep 15, 2019
@blink1073 blink1073 merged commit 6fc9a7e into ipython:master Sep 15, 2019
@jasongrout
Copy link
Member

Thanks for this, @impact27. I just ran into this problem as well when closing a comm from the browser, and it's nice to know all I need to is upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@impact27 @ccordoba12 @jasongrout @blink1073