Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
`post_execute` and `post_run_cell` hooks not always triggered #10774
Thanks for the report, you are right that we should split the post_execution hooks into hooks that execute after every requests, or only after every valid Python request. I don't think we should fix the current ones, but provide variants that also trigger even when the pre-execute fails.
Hey @Carreau -- I'm curious about the details of what you're proposing.
Thinking it through, I could see an argument that the right answer here is to say "we will be explicit about documenting and sticking to the current behavior, because it's a subtle behavior change. If you want something else, you should override
Probably not that granular.
I see you are 0-indexed. And so we have at least 1 more data point: I would have expected these hooks to not trigger on failure :-)
Yes, probably a
We'll better document anyway !