[Flow] Change the definition of "dequantization" recognizer. #17711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
added
benchmarks:cuda
Abbreviated Benchmark Summary@ commit 88f32fab4c2503c4b8cf1d43f1480ae1467e5788 (vs. base 90f29a66d5bbd58167d84b2011d27c7ffb9a1ee1) Data-Tiling Comparison TableClick to show
Regressed Latencies 🚩
[Top 3 out of 6 results showed] Improved Latencies 🎉
[Top 3 out of 12 results showed] Regressed Total Dispatch Sizes 🚩
[Top 3 out of 8 results showed] Regressed Total Artifact Sizes 🚩
Improved Stream IR Dispatch Count (# of cmd.dispatch ops) 🎉
[Top 3 out of 11 results showed] For more information: |
hanhanW
approved these changes
Jun 20, 2024
compiler/src/iree/compiler/Dialect/Flow/Transforms/RegionOpUtils.cpp
Outdated
Show resolved
Hide resolved
MaheshRavishankar
force-pushed
the
sdxl_quantized_fix_dequant_op_def
branch
from
1e4b977
to
abd591b
Compare
The dequantization operation today is trying to enforce that the input indexing map is an identity. This is overly conservative for newer quantization schemes. This changes the logic to just look at operand ranks to check if the operation is a dequantization operation. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
force-pushed
the
sdxl_quantized_fix_dequant_op_def
branch
from
abd591b
to
a1888f9
Compare
MaheshRavishankar
force-pushed
the
sdxl_quantized_fix_dequant_op_def
branch
from
883f0a1
to
27533a3
Compare
Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
force-pushed
the
sdxl_quantized_fix_dequant_op_def
branch
from
27533a3
to
d8a3fe5
Compare
hanhanW
approved these changes
Jun 25, 2024
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
…g#17711) The dequantization operation today is trying to enforce that the input indexing map is an identity. This is overly conservative for newer quantization schemes. This changes the logic to just look at operand ranks to check if the operation is a dequantization operation. --------- Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com> Signed-off-by: Lubo Litchev <lubol@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dequantization operation today is trying to enforce that the input indexing map is an identity. This is overly conservative for newer quantization schemes. This changes the logic to just look at operand ranks to check if the operation is a dequantization operation.