Preparing VM op defs and dispatch for supporting extension op sets. #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efs. This makes it easier to read and could be auto generated at some point. Progress on #2574.
benvanik
added
enhancement ➕
This makes it easier to support more types as now fewer locations have special-case logic on the exact typed global op and there's a single source of truth for rwdata placement.
ScottTodd
approved these changes
Jul 20, 2020
| @@ -234,7 +243,9 @@ def VM_OpcodeAttr : I32EnumAttr<"Opcode", "valid VM operation encodings", [ | |||
| VM_OPC_Break, | |||
|
|
|||
| // Extension opcodes (0x80-0xFF): | |||
There was a problem hiding this comment.
:P of course there's already a section for extension opcodes to be added. Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make future work on #2574 easier to slot in.