Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --iree-vm-target-* flags to control index bit width and i64 support #2742

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Adding --iree-vm-target-* flags to control index bit width and i64 support #2742

merged 6 commits into from
Aug 14, 2020

Conversation

benvanik
Copy link
Collaborator

@benvanik benvanik commented Jul 31, 2020 •
edited
Loading

This allows us to specify a consistent type converter for all lowering into VM and adds options to control the handling of index and i64.

Fixes #2574.

@benvanik benvanik added enhancement ➕ New feature or request compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) labels Jul 31, 2020
@benvanik benvanik added this to the 2020Q3 Core milestone Jul 31, 2020
@google-cla google-cla bot added the cla: yes label Jul 31, 2020
@benvanik benvanik requested a review from ScottTodd July 31, 2020 23:01
@benvanik benvanik mentioned this pull request Jul 31, 2020
Closed
5 tasks
@benvanik benvanik force-pushed the benvanik-vm64-flags branch 2 times, most recently from e0e77b1 to 37c2dcd Compare August 1, 2020 02:05
@benvanik
Copy link
Collaborator Author

benvanik commented Aug 1, 2020

I think I'm hitting an MLIR issue here and have filed a bug upstream: https://bugs.llvm.org/show_bug.cgi?id=46944

ScottTodd
ScottTodd approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM once the dialect conversion issue is resolved in some way

Base automatically changed from benvanik-vm64-i64 to main August 6, 2020 22:14
@benvanik benvanik force-pushed the benvanik-vm64-flags branch 2 times, most recently from b2048f8 to 1128f78 Compare August 13, 2020 23:23
@benvanik benvanik marked this pull request as ready for review August 13, 2020 23:29
@benvanik benvanik merged commit 064dd2b into main Aug 14, 2020
@benvanik benvanik deleted the benvanik-vm64-flags branch August 14, 2020 00:21
@GMNGeoffrey GMNGeoffrey mentioned this pull request Aug 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

Assignees
No one assigned
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) enhancement ➕ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support extension op sets in the VM compiler and runtime for i64/f32/f64
2 participants
@benvanik @ScottTodd