Skip to content

Conversation

Charlesvdb
Copy link

No description provided.

@MFn-Scarboy
Copy link

MFn-Scarboy commented Feb 21, 2020

  • Technical Requirements (10/10)

  • Creative Code (9/10)

  • Code Quality (9/10)

Iteration #6
The 'break's are unnecessary.
Your 'for' loop only runs once (try to see why).

Overall good, indentation could be cleaner

Edit* was running the code against an un-updated test, corrected feedback.

-- Joel

@stale
Copy link

stale bot commented Mar 22, 2020

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 22, 2020
@stale
Copy link

stale bot commented Mar 24, 2020

This pull request is closed. Thank you.

@stale stale bot closed this Mar 24, 2020
@stale
Copy link

stale bot commented Mar 26, 2020

This pull request is closed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants