[FTRMT052023] - Maria Friedemann #3815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TA-Remote
reviewed
May 12, 2023
| if (array[i] === 0) { | ||
| return 0; | ||
| } else { | ||
| return sumOfNumbers; |
There was a problem hiding this comment.
Here that return is inside the for...loop if you move it outside and remove the if...else that function would work correctly
| } | ||
| let sumOfStrings = 0; | ||
| for (let i = 0; i < array.length; i++) { | ||
| sumOfStrings += array[i]; |
There was a problem hiding this comment.
If you add that one you would get the tests passing, we want the average length of the word :)
Suggested change
| sumOfStrings += array[i]; | |
| sumOfStrings += array[i].length; |
| ]; | ||
|
|
||
| function howManyTimes() {} | ||
| function howManyTimes(array) { |
There was a problem hiding this comment.
Here you needed another parameter to pass what was searched
Suggested change
| function howManyTimes(array) { | |
| function howManyTimes(array, search) { |
| let count = 0; | ||
|
|
||
| for (let i = 0; i < array.length; i++) { | ||
| for (let j = 0; j < array.length; j++) { |
There was a problem hiding this comment.
and with the other parameter you won't need the second loop
Suggested change
| for (let j = 0; j < array.length; j++) { | |
| if (array[i] === search) { | |
| count ++; | |
| } |
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That lab was so challenging for me. I got stuck right away and spent hours on the different iterations and still could not finish:( I think there is something in the main methodology that still has not sunk in yet.