Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should tshy.selfLink default to false on Windows? #20

Closed
isaacs opened this issue Oct 25, 2023 · 0 comments · Fixed by #30
Closed

should tshy.selfLink default to false on Windows? #20

isaacs opened this issue Oct 25, 2023 · 0 comments · Fixed by #30

Comments

@isaacs
Copy link
Owner

isaacs commented Oct 25, 2023

I keep having to set this explicitly because my Windows vm doesn't allow symlinks in the way tshy tries to create them.

It's also really only a nice to have, because tsc will resolve importing self-exports already, based on the exports in ./package.json, and the deployed package will be able to walk up the tree to find the root package.json and resolve the exports properly, without the symlink.

It's only needed if you are importing self-exports, and load your code from ./dist in tests or something.
isaacs added a commit that referenced this issue Nov 4, 2023
@isaacs
make the selfLink a best effort if not explicitly true
c86ea27 
This stops it from always failing on Windows which is making me so
annoyed when I have to debug stuff on my windows VM.

Fix: #20
@isaacs isaacs mentioned this issue Nov 4, 2023
Merged
isaacs added a commit that referenced this issue Nov 4, 2023
@isaacs
make the selfLink a best effort if not explicitly true
b7c6b62 
This stops it from always failing on Windows which is making me so
annoyed when I have to debug stuff on my windows VM.

Fix: #20
@isaacs isaacs closed this as completed in 4acf045 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make the selfLink a best effort if not explicitly true isaacs/tshy
1 participant
@isaacs