Skip to content

fix: eliminate Mutex's reliance on setInterval #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2020
Merged

fix: eliminate Mutex's reliance on setInterval #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fe2f78
make Mutex less reliant on timers firing on time
billiegoose Mar 4, 2020
89a79e0
improvements
billiegoose Mar 4, 2020
fbc7fa9
cleanup
billiegoose Mar 4, 2020
5866a56
cleanup
billiegoose Mar 4, 2020
154f89c
chore: bump browsers
billiegoose Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
env:
BROWSER_STACK_ACCESS_KEY: $(BROWSER_STACK_ACCESS_KEY)
BROWSER_STACK_USERNAME: $(BROWSER_STACK_USERNAME)
BUNDLESIZE_GITHUB_TOKEN: $(BUNDLESIZE_GITHUB_TOKEN)
BUNDLEWATCH_GITHUB_TOKEN: $(BUNDLEWATCH_GITHUB_TOKEN)
SAUCE_ACCESS_KEY: $(SAUCE_ACCESS_KEY)
SAUCE_USERNAME: $(SAUCE_USERNAME)
TEST_BROWSERS: 'ChromeHeadlessNoSandbox,FirefoxHeadless,sl_ios_safari'
TEST_BROWSERS: 'ChromeHeadlessNoSandbox,FirefoxHeadless,sl_edge,sl_safari,sl_ios_safari,bs_android_chrome'

- task: PublishTestResults@2
displayName: 'Save test results'
Expand Down
46 changes: 32 additions & 14 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,44 +71,60 @@ module.exports = function (config) {
XXXsl_chrome: {
base: 'SauceLabs',
browserName: 'chrome',
extendedDebugging: true
extendedDebugging: true,
},
sl_firefox: {
XXXsl_firefox: {
base: 'SauceLabs',
browserName: 'firefox'
browserName: 'firefox',
},
sl_edge: {
base: 'SauceLabs',
browserName: 'MicrosoftEdge'
browserName: 'MicrosoftEdge',
version: '79.0',
},
sl_safari: {
base: 'SauceLabs',
browserName: 'safari'
browserName: 'safari',
platform: 'macOS 10.15',
version: '13.0',
},
sl_ios_safari: {
base: 'SauceLabs',
deviceName: 'iPhone X Simulator',
deviceName: 'iPhone 11 Pro Max Simulator',
platformName: 'iOS',
platformVersion: '11.2',
platformVersion: '13.0',
browserName: 'Safari',
appiumVersion: '1.9.1'
appiumVersion: '1.15.0',
},
sl_android_chrome: {
XXXsl_android_chrome: {
base: 'SauceLabs',
deviceOrientation: 'portrait',
deviceName: 'Android GoogleAPI Emulator',
platformName: 'Android',
platformVersion: '7.1',
browserName: 'Chrome',
appiumVersion: '1.9.1'
appiumVersion: '1.15.0',
},
bs_android_chrome: {
base: 'BrowserStack',
os: 'android',
os_version: '10.0',
browser: 'android',
device: 'Google Pixel 4',
real_mobile: true,
},
FirefoxHeadless: {
base: 'Firefox',
flags: ['-headless']
flags: ['-headless'],
},
ChromeHeadlessNoSandbox: {
base: 'ChromeHeadless',
flags: ['--no-sandbox']
}
flags: ['--no-sandbox'],
},
ChromeCanaryHeadlessNoSandbox: {
base: 'ChromeCanaryHeadless',
flags: ['--no-sandbox'],
},
},
sauceLabs: {
// Since tags aren't being sent correctly, I'm going to stick the branch name in here.
Expand All @@ -121,7 +137,7 @@ module.exports = function (config) {
tags: [ISSUE],
recordScreenshots: false,
recordVideo: false,
public: 'public restricted'
public: 'public restricted',
},
concurrency: 5,
// Continuous Integration mode
Expand All @@ -138,8 +154,10 @@ module.exports = function (config) {
devtool: 'inline-source-map',
},
plugins: [
'karma-browserstack-launcher',
'karma-chrome-launcher',
'karma-edge-launcher',
'karma-ie-launcher',
'karma-safari-launcher',
'karma-firefox-launcher',
'karma-jasmine',
Expand Down
Loading