Improve row decoding in v3 API #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
reviewed
Jul 30, 2023
isoos
approved these changes
Jul 30, 2023
|
published as 2.6.2 |
|
Awesome, thanks! |
|
Thanks for the great work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the v3 API, we're using the simple query protocol when there are no variables in the query. Unfortunately, rows are always returned in the textual format with that protocol. As the binary decoder is more efficient and supports more types, we'd like to use that one instead.
For users that know they won't need any rows, I've added the
schemaOnlyparameter toexecute. When enabled and there are no parameters, we can still use the simple query protocol as an optimization.This fixes #101.