Skip to content

update allowReuse nullability #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2021
Merged

update allowReuse nullability #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 2.4.1+1

- Fix error when passing `allowReuse: null` into `query()` [#8](https://github.com/isoos/postgresql-dart/pull/8)

## 2.4.1

- Support for type `interval`, [#10](https://github.com/isoos/postgresql-dart/pull/10).
Expand Down
8 changes: 4 additions & 4 deletions lib/src/connection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,13 +416,13 @@ abstract class _PostgreSQLExecutionContextMixin
Future<PostgreSQLResult> query(
String fmtString, {
Map<String, dynamic>? substitutionValues,
bool? allowReuse = true,
bool? allowReuse,
int? timeoutInSeconds,
}) =>
_query(
fmtString,
substitutionValues: substitutionValues,
allowReuse: allowReuse!,
allowReuse: allowReuse ?? true,
timeoutInSeconds: timeoutInSeconds,
);

Expand Down Expand Up @@ -467,12 +467,12 @@ abstract class _PostgreSQLExecutionContextMixin
Future<List<Map<String, Map<String, dynamic>>>> mappedResultsQuery(
String fmtString,
{Map<String, dynamic>? substitutionValues = const {},
bool? allowReuse = false,
bool? allowReuse,
int? timeoutInSeconds}) async {
final rs = await query(
fmtString,
substitutionValues: substitutionValues,
allowReuse: allowReuse!,
allowReuse: allowReuse ?? false,
timeoutInSeconds: timeoutInSeconds,
);

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: postgres
description: PostgreSQL database driver. Supports statement reuse and binary protocol.
version: 2.4.1
version: 2.4.1+1
homepage: https://github.com/isoos/postgresql-dart

environment:
Expand Down